Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #32622

Closed (moved)
(moved)
Open
Created Nov 26, 2019 by Philipp Winter@phw

Fix misleading STATUS_CLIENT warning message

After Tor 0.4.3.0-alpha-dev successfully established a TCP connection with a bridge but failed to finish its handshake, it sends the following STATUS_CLIENT message to the controller:

650 STATUS_CLIENT WARN BOOTSTRAP PROGRESS=10 TAG=handshake_dir SUMMARY="Finishing handshake with directory server" WARNING="DONE" REASON=DONE COUNT=1 RECOMMENDATION=warn HOSTID="0000000000000000000000000000000000000000" HOSTADDR="[scrubbed]"

One can reproduce this by using torproject.org's web server as a bridge: 95.216.163.36:80. The substring WARNING="DONE" is misleading and should – if I'm interpreting control-spec.txt correctly – contain a human-readable description of what went wrong. Other STATUS_CLIENT messages do a better job; for example:

650 STATUS_CLIENT WARN BOOTSTRAP PROGRESS=5 TAG=conn_dir SUMMARY="Connecting to directory server" WARNING="Connection refused" REASON=CONNECTREFUSED COUNT=1 RECOMMENDATION=warn HOSTID="0000000000000000000000000000000000000000" HOSTADDR="[scrubbed]"

Here, the substring WARNING="Connection refused" gives me a good idea of what's going on.

I suggest to fix the warning in this particular error case.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking