Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #33011

Closed (moved)
(moved)
Open
Created Jan 21, 2020 by David Fifield@dcf

Remove erroneous logging around pt.*Error calls

#31794 (moved) added logging around every function call that returns an error type; but this is the wrong thing to do in the case of functions like pt.CmethodError, pt.SmethodError, and pt.ProxyError. These functions are called for their side effect of sending a PT error message on stdout; it happens that they also return a representation of the error message as an error object for the caller to use if it wishes. They always return a non-nil error object; a non-nil error is not an exceptional event to be logged.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking