Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #33097

Closed (moved)
(moved)
Open
Created Jan 29, 2020 by Nick Mathewson@nickm🍬

outbuf_flushlen seems to serve no purpose

The "outbuf_flushlen" field in connection_t seems to not actually do anything that's distinct from buf_datalen(conn->outbuf)... except possibly, to get out of sync with it under rare conditions? (eg #32472 (moved)).

Flushlen once existed to implement rate limiting: it was introduced in 117cbeeaaf30cdb before we even had round robining. Later there was some logic involved with f5ebf4c712d693c to try to flush full TLS records. And controller connections used ab838bddb89f to force early flushing there... but right now, we don't flush according to the same logic that we used to flush, and I think outbuf_flushlen is now obsolete.

I think there's a case to be made for removing this field in 0.4.3, but I'd like to be cautious.

Adding arma to cc in case he can remember what outbuf_flushlen is for.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking