Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #33592

Closed (moved)
Open
Opened Mar 11, 2020 by weasel (Peter Palfrader)@weasel

drop http public key pinning

http PKP has been deprecated and removed from many browsers already.

We should stop sending that header.

I propose a 2 stage process:

  1. get clients that visit us regularly to drop their cached pin
  2. after all pins would also have expired, stop sending the header entirely.

for 1, something like this

--- a/modules/apache2/templates/ssl-key-pins.erb
+++ b/modules/apache2/templates/ssl-key-pins.erb
@@ -24,7 +24,9 @@
     if pin_info.size >= 2 then
       pin_info = pin_info.map{ |x| x.gsub('"', '\"') }
       # 60 days
-      pin_info << "max-age=5184000"
+      #pin_info << "max-age=5184000"
+      # 0 days, set 2020-03-11, so we can get rid of the header around 2020-05-11.
+      pin_info << "max-age=0"
       pin_str = pin_info.join("; ")
       res << "  Header always set Public-Key-Pins \"#{pin_str}\""
     else

also cf https://tools.ietf.org/html/rfc7469#section-2.3.1

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#33592