Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #33676

Closed (moved)
Open
Opened Mar 20, 2020 by teor@teor

Stop waiting a set time for microdescriptors

Your code in #33675 (moved) needs to pass your local "make test-network-all", on master and maint-0.3.5, before you start this ticket.

When we make chutney check for microdescriptors, we can stop waiting a set time for microdescriptors to download.

Please read these instructions carefully. Don't leave out any steps!

First, set MIN_START_TIME_LEGACY and NODE_WAIT_FOR_UNCHECKED_DIR_INFO to 0: https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L926 https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L952

Then check that make test-network-all still passes on:

  • Tor master, and
  • Tor maint-0.3.5

You can build a different tor branch using the following commands:

git checkout <branch>
make

Check the new code on your own machine, and then submit a pull request to run Chutney's CI.

If all those tests pass, you can remove all the code that uses MIN_START_TIME_LEGACY and NODE_WAIT_FOR_UNCHECKED_DIR_INFO:

  • remove NODE_WAIT_FOR_UNCHECKED_DIR_INFO
  • replace NODE_WAIT_FOR_UNCHECKED_DIR_INFO with 0 in getUncheckedDirInfoWaitTime()
  • remove getMinStartTime()
  • remove all the constants getMinStartTime() uses
  • remove all calls to getMinStartTime()
  • remove all the variables, code, and comments that depend on getMinStartTime()
    • https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2224
    • https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2273

Then add a commit to your pull request with these changes, and check that they pass CI.

You can ignore macOS hangs ("red ! symbol") on Travis CI. It is a bit unstable right now.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#33676