Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #33807
Closed (moved) (moved)
Open
Issue created Apr 03, 2020 by Matthew Finkel@sysrqb

Namecoin eTLD patch conflicted with securedrop.tor.onion

/tmp/tmp.EB97rs4a6X/z /var/tmp/dist/firefox
/var/tmp/dist/firefox
Starting build: Fri Apr  3 08:07:15 2020
/var/tmp/dist/gcc/bin ~
~
patching file mobile/android/app/src/main/assets/publicsuffixlist
patching file netwerk/dns/effective_tld_names.dat
Hunk #1 FAILED at 5480.
1 out of 1 hunk FAILED -- saving rejects to file netwerk/dns/effective_tld_names.dat.rej

where the namecoin eTLD patch (projects/firefox/namecoin-etld.patch) does:

diff --git a/netwerk/dns/effective_tld_names.dat b/netwerk/dns/effective_tld_names.dat
index 9dd962a..3402b20 100644
--- a/netwerk/dns/effective_tld_names.dat
+++ b/netwerk/dns/effective_tld_names.dat
@@ -5480,6 +5480,7 @@ pro.om

 // onion : https://tools.ietf.org/html/rfc7686
 onion
+bit.onion

 // org : https://en.wikipedia.org/wiki/.org
 org

It's an easy fix.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking