Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #33954

Closed (moved)
Open
Opened Apr 21, 2020 by Alex Catarineu@acat

Consider different approach for "2176: Rebrand Firefox to TorBrowser "

The current patch replaces all occurrences of branding/brand.ftl with branding/tor-browser-brand.ftl. This means that many files are touched by the patch (increasing chances of rebase conflict), and whenever Firefox adds new instances of branding/brand.ftl we need to modify the patch to also cover those.

I think we should try a different approach to keep all instances of branding/brand.ftl untouched, and do the branding/brand.ftl -> branding/tor-browser-brand.ftl remapping somewhere else, and just in a single place.

One way would be to force the Fluent FileSource that we register in torbutton to take precedence over any other source and rename tor-browser-brand.ftl to brand.ftl, to override Firefox one (including langpacks).

We probably would need to do this in L10nRegistry.js, but I would need to investigate a bit more.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#33954