Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #33956
Closed (moved) (moved)
Open
Issue created Apr 22, 2020 by teor@teor

Define and use TOR_ADDRPORT_BUF_LEN

In #33918 (moved), we discovered a bug where IPv6 addresses were being truncated in logs.

During the fix, we noticed that we had a TOR_ADDR_BUF_LEN, but no equivalent constant for addresses and ports. The new TOR_ADDRPORT_BUF_LEN should allow space for:

  • TOR_ADDR_BUF_LEN
  • IPv6 brackets (2, if not included in TOR_ADDR_BUF_LEN already)
  • the port separator (1)
  • the port (5)

We should check for other truncation errors while making this change.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking