Use and document 'tbb-backport' in the release process

Include checking of https://trac.torproject.org/projects/tor/tags/tbb-backport for possible backports in every stable release preparation.

added TorBrowserTeam202004 component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed type::defect labels

In ticket:32405#comment:7, it was used incorrectly.

#32505 (moved), #32414 (moved), #32493 (moved) are ready for Tor Browser 9.0.10.

Replying to cypherpunks:

In ticket:32405#comment:7, it was used incorrectly.

I removed the superfluous tbb-backport.

Replying to cypherpunks:

#32505 (moved), #32414 (moved), #32493 (moved) are ready for Tor Browser 9.0.10.

That does not necessarily follow. tbb-backport means tickets tagged with it could be considered for getting backported contrary to those we deem right from the beginning as not eligible for backport.

However, whether they actually get backported depends on a number of reasons. We have only a small number of alpha users and as any backport still has a remaining risk of breaking things, this exacerbates that the risk. There are other factors to consider, like how close we are to the next major stable anyway etc.

At the end there is no guarantee that things tagged with tbb-backport get backported. As I said above those tickets could be considered for a backport.

And, yes, we are using the tag in the release process.

Trac:
Resolution: N/A to fixed
Status: new to closed

Oh, and I updated https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser/Hacking accordingly so that our use of tbb-backport is documented there.

And, yes, we are using the ticket in the release process. s/ticket/tag At the end there is no guarantee that things tagged with tbb-backport get backported. They should be re-tagged or cleared out of it every major stable update. And that should be documented and used as part of the release process.

Oh, and I updated https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser/Hacking accordingly so that our use of tbb-backport is documented there. The hyperlink https://trac.torproject.org/projects/tor/query?status=!closed&keywords=~tbb-backport is a search query which lists tbb-backported too. That's why it cannot be used.

Could you backport #32493 (moved) to get parity with tba?

Replying to cypherpunks:

And, yes, we are using the ticket in the release process. s/ticket/tag

Thanks, fixed.

At the end there is no guarantee that things tagged with tbb-backport get backported. They should be re-tagged or cleared out of it every major stable update. And that should be documented and used as part of the release process.

They do get cleared out with every major stable update and I just amended the text on the hacking document.

Oh, and I updated https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser/Hacking accordingly so that our use of tbb-backport is documented there. The hyperlink https://trac.torproject.org/projects/tor/query?status=!closed&keywords=~tbb-backport is a search query which lists tbb-backported too. That's why it cannot be used.

Yeah, I added a better link.

Could you backport #32493 (moved) to get parity with tba?

It does not seem like we do this for the upcoming stable release and the next regular stable one is 9.5.

Yeah, I added a better link. So error-prone that #21549 (moved) is missed right now :( It does not seem like we do this for the upcoming stable release and the next regular stable one is 9.5. Then it will be the first minor stable release you don't use to test your improvements (except version updates). That means you will lose the whole release cycle to receive feedback from the users :(

BTW, what's wrong with with the variant in the comment:description for you? tbb-backport doesn't seem to be documented in https://gitweb.torproject.org/tor-browser-spec.git/tree/processes/ReleaseProcess

Replying to cypherpunks:

BTW, what's wrong with with the variant in the comment:description for you?

Nothing.

tbb-backport doesn't seem to be documented in https://gitweb.torproject.org/tor-browser-spec.git/tree/processes/ReleaseProcess

Yes, because that document describes the process for getting a release out once all patches have landed. Considerations about which patch should actually get backported for which release happen before that.

Replying to gk:

Replying to cypherpunks:

BTW, what's wrong with with the variant in the comment:description for you?

Nothing. Then it's not clear why you don't use it.

tbb-backport doesn't seem to be documented in https://gitweb.torproject.org/tor-browser-spec.git/tree/processes/ReleaseProcess

Yes, because that document describes the process for getting a release out once all patches have landed. Considerations about which patch should actually get backported for which release happen before that. Thanks for the clarification. It seems we need ReleasePreparationProcess document ;)

closed

moved to tpo/applications/tor-browser#34055 (closed)