Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #34191

Closed (moved)
Open
Created May 12, 2020 by Karsten Loesing@karsten

Combine multiple analysis files into single data set

OnionPerf's visualize mode currently supports specifying multiple data sets to be graphed with different labels for each data set. However, for each data set it's only possible to specify exactly one analysis results file. If we ever want to graph a data set covering more than a single day and compare that to another data set, we cannot do that at the moment.

Here's a possible user interface extension to allow specifying one or more analysis results files for each data set:

diff --git a/onionperf/onionperf b/onionperf/onionperf
index cb1899c..957c6df 100755
--- a/onionperf/onionperf
+++ b/onionperf/onionperf
@@ -326,8 +326,9 @@ files generated by this script will be written""",
     visualize_parser.set_defaults(func=visualize, formatter_class=my_formatter_class)
 
     visualize_parser.add_argument('-d', '--data',
-        help="""Append a PATH to a onionperf.analysis.json analysis results file, and a LABEL that we
-        should use for the graph legend for this dataset""",
+        help="""Append a file or directory PATH to an onionperf.analysis.json
+                analysis results file or directory of such files, and a LABEL
+                that we should use for the graph legend for this dataset""",
         metavar=("PATH", "LABEL"),
         nargs=2,
         required="True",

I didn't write any other code for this yet.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None