Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #34249

Closed (moved)
(moved)
Open
Created May 18, 2020 by teor@teor

Make sure the C and Rust protovers can't get out of sync

There is a recurring bug, where we modify the C protover, but forget the Rust protover. (See #34248 (moved), #33285 (moved), #29631 (moved) for similar issues.)

We could fix the underlying issue by fetching the string from a common location, using C's #include or Rust's include_str!().

Then we could test that C and Rust are the same by putting a copy of the protover string in the unit tests, and making sure that it matches the currently supported protocol versions.

This fix and test will be important for proposal 318, because it will modify both protocol version implementations: https://github.com/torproject/torspec/blob/master/proposals/318-limit-protovers.md

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking