Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #34251

Closed (moved)
Open
Created May 18, 2020 by teor@teor

Fix edge case handling in Rust protover is supported

Tor's Rust FFI for protocol_list_supports_protocol_or_later() returns true for the empty protocol list.

In C, the function returns false, but this behaviour is undocumented.

This bug doesn't affect protocol_list_supports_protocol() in Rust, because the Rust error checks are done in a different order.

I'll add a quick fix to #33222 (moved), but someone else will need to do the backport. We might want to do the Rust error checks in the same order, too.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.4.5.x-final
Milestone
Tor: 0.4.5.x-final
Assign milestone
Time tracking
None
Due date
None