Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #34251

Closed (moved)
(moved)
Open
Created May 18, 2020 by teor@teor

Fix edge case handling in Rust protover is supported

Tor's Rust FFI for protocol_list_supports_protocol_or_later() returns true for the empty protocol list.

In C, the function returns false, but this behaviour is undocumented.

This bug doesn't affect protocol_list_supports_protocol() in Rust, because the Rust error checks are done in a different order.

I'll add a quick fix to #33222 (moved), but someone else will need to do the backport. We might want to do the Rust error checks in the same order, too.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking