Skip to content

GitLab

Trac
Trac

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by Roger Dingledine@arma

netinfo cells declare canonical address for the remote OR, not actual address of the conn

In connection_or_send_netinfo() we write

  /* Their address. */
  out = cell.payload + 4;
  len = append_address_to_payload(out, &conn->_base.addr);

But the goal here is to say the actual address the conn came from/to, yes? If so, shouldn't it be conn->real_addr?

Reported by "troll_un".

Targeting this one on 0.2.2 since when we eventually start using the contents of netinfo cells, we'll wish everybody had the fix.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information