Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #4349

Closed (moved)
(moved)
Open
Created Oct 29, 2011 by Roger Dingledine@arma

netinfo cells declare canonical address for the remote OR, not actual address of the conn

In connection_or_send_netinfo() we write

  /* Their address. */
  out = cell.payload + 4;
  len = append_address_to_payload(out, &conn->_base.addr);

But the goal here is to say the actual address the conn came from/to, yes? If so, shouldn't it be conn->real_addr?

Reported by "troll_un".

Targeting this one on 0.2.2 since when we eventually start using the contents of netinfo cells, we'll wish everybody had the fix.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking