Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #4353

Closed (moved)
(moved)
Open
Created Oct 30, 2011 by Sebastian Hahn@sebastian

Tor clients without geoip DB log that they are configured to collect stats

this is confusing, and might provoke some "OMG I AM A CLIENT WHAT KIND OF STATS ARE YOU COLLECTING" arguments (two people on #tor asked about this and one on the blog, now I know how they learned about stats stuff).

probably a patch like this:


diff --git a/src/or/config.c b/src/or/config.c
index ca4e71c..01d4036 100644
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -1410,8 +1410,9 @@ options_act(or_options_t *old_options)
     tor_free(actual_fname);
   }
 
-  if (options->CellStatistics || options->DirReqStatistics ||
-      options->EntryStatistics || options->ExitPortStatistics) {
+  if (server_mode(options) &&
+      (options->CellStatistics || options->DirReqStatistics ||
+       options->EntryStatistics || options->ExitPortStatistics)) {
     time_t now = time(NULL);
     int print_notice = 0;
     if ((!old_options || !old_options->CellStatistics) &&

or something would fix it, but I need to look closer at it.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking