Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #4442

Closed (moved)
(moved)
Open
Created Nov 09, 2011 by Nick Mathewson@nickm🍬

The crypto in aes.c should use openssl's EVP_ functions.

It looks like we're not getting the full benefits of OpenSSL's hardware acceleration support, since the AES_encrypt function does the crypto directly in C or asm (typically asm), rather than redirecting to an engine if one is present.

Whoops!

So, let's fix that.

I believe that it's sufficient to just define USE_OPENSSL_EVP in aes.c. Also, we should really rip out the bits of that file which we don't use -- we're no longer in a position where our fallback implementation is ever a better idea to openssl's.

We should benchmark this change to make sure that it's not a step backwards -- I doubt it is.

Also, we should consider using EVP_ functions for SHA1 and SHA256 when present. For RSA and DH, however, the OpenSSL RSA_ and DH_ functions already know about engines.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking