managed proxies: "[notice] Failed to terminate process with PID '%d'" when doing Ctrl-c from terminal
I noticed the following in my logs:
"[notice] Failed to terminate process with PID '%d'"
while I was testing managed proxies.
This happened because I terminate tor by doing Ctrl-c in a terminal, which sends a SIGINT to the whole process group (including obfpsroxy). This kills obfsproxy. Then, when I kill tor with a second Ctrl-c, tor tries to terminate all the managed proxies which are already dead. This prints the above line.
Maybe this is not even a bug, but I think it could be a good idea to tone down the log severity to info, when errno is ESRCH
.
In any case, we should print the errno string along with the error message.