Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #4978

Closed
Open
Opened Jan 28, 2012 by Trac@tracbot

I found a small bug in TorCtl.py, in connection.map_address()

In method connection.map_address() in TorCtl.py, the following line is supposed to build the line to be sent to the tor control port in order to map a list of adresses:

m = " ".join([ "%s=%s" for k,v in kvList])

The string "%s=%s" lacks formatting. Better:

m = " ".join([ "%s=%s" (k,v) for (k,v) in kvList])

My first contrib to open source (: I hope this is the right place for this

Trac:
Username: derpington

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#4978