GitLab

connection_handle_read_impl() says

 * This function gets called from conn_read() in main.c, either
 * when poll() has declared that conn wants to read, or (for OR conns)
 * when there are pending TLS bytes.

First of all, there is no conn_read() anymore. But also, I suspect this function is no longer called when there are pending TLS bytes?

I worry that libevent only calls the callback when the socket has something to read, and not when the ssl object has pending bytes. That would mean we are forced to keep our "read the whole ssl record even if it means our read bucket goes negative" feature? See #5323 (moved).