Skip to content

GitLab

Trac
Trac

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by Anthony Basile@blueness

tor-0.2.3.12_alpha: ./configure --enable-upnp fails when using miniupnpc-1.6

There is a change in miniupnpc from 1.5 to 1.6 causing tor-0.2.3.12_alpha to fail to configure with --enable-upnp. The definition of upnpDiscover() prototyped in <miniupnpc/miniupnpc.h> changed from

LIBSPEC struct UPNPDev * upnpDiscover(int delay, const char * multicastif, const char * minissdpdsock, int sameport);

to

LIBSPEC struct UPNPDev * upnpDiscover(int delay, const char * multicastif, const char * minissdpdsock, int sameport, int ipv6, int * error);

This causes the test program generated by ./configure to fail since it tries to call upnpDiscover(1, 0, 0, 0 ); That's an easy fix, but more involved is the only call made to upnpDiscover which is in src/tools/tor-fw-helper/tor-fw-helper-upnp.c. ipv6 should be disabled, but should int * error be handled?

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information