Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #5543

Closed (moved)
(moved)
Open
Created Apr 01, 2012 by Nick Mathewson@nickm🍬

BridgePassword would be insecure if anybody used it

The "BridgePassword" option, which a bridge authority can use to provide debugging information, has a stupid side-channel bug: it uses strcmp() to compare the received authenticator with the expected value.

Fortunately, the bridge authority isn't (and hasn't been) using this option, so there is no actual target for the side-channel attack now. (Also, it's pretty hard to get fine-grained timing information out of a loaded Tor server. But we shouldn't count on that.)

The right short-term fix is probably to hash the BridgePassword when it is set, and then to hash any any provided authenticator and compare it against the hashed value.

The right longer-term fix is to replace BridgePassword with something akin to HashedControlPassword, or to remove it entirely.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking