Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #5786

Closed (moved)
Open
Opened May 06, 2012 by George Kadianakis@asn

A single authority can crash the other authorities

boboper found a couple of assertion failures in dirauth vote parsing functions:

< boboper> "0 < weight_scale" what a silly style?
< boboper> lol "weight_scale < INT32_MAX" it's natural bugdoor.
< boboper> as well as zero compare
< boboper> good to know you filled your ignore list. I can slowly  develop mine exploits. I found that irc helps me to do it better.
< boboper> "tor_parse_long(eq+1, 10, INT32_MIN, INT32_MAX, &ok, NULL)" "tor_assert(ok)" one mad auth can destroy all network. I wanna be auth.
< boboper> or_parse_long(eq+1, 10, INT32_MIN, INT32_MAX, &ok, NULL); can't detect overflow and underflow for 32bit. LONG_MIN == INT32_MIN
< boboper> "tor_assert(i<n_votes)" you re so funny devs
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.2.3.x-final
Milestone
Tor: 0.2.3.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#5786