Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #5978

Closed (moved)
Open
Opened May 29, 2012 by Nick Mathewson@nickm🐙

Dead code, possible races, in NT service code

So, the nt_service_set_status function does nothing. (At least, not without a subsequent call to SetServiceStatus_fn, which there isn't).

Also, everything that sets or checks dwCurrentState in ntmain.c needs to be checked for race conditions, and to make sure that it isn't missing a call to QueryServiceStatus and/or SetServiceStatus.

(Reported pseudonymously on IRC. I probably have some details wrong here; more investigation will help)

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#5978