Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #6759

Closed (moved)
(moved)
Open
Created Sep 03, 2012 by Roger Dingledine@arma

Don't tell user about reloading microdesc cache at startup

Sep 03 18:12:41.000 [notice] Reloaded microdescriptor cache.  Found 0 descriptors.

is there on initial startup every time.

If you've already got lots of dir info, it would say e.g.

Sep 03 18:24:41.000 [notice] Reloaded microdescriptor cache.  Found 3035 descriptors.

Our bootstrap warnings are supposed to tell the user when there's a problem, and our bootstrap notices say when there isn't. We don't need this extra line.

I had originally thought to do a fancier fix like:

-  log_notice(LD_DIR, "Reloaded microdescriptor cache.  Found %d descriptors.",
-             total);
+  log(total ? LOG_NOTICE : LOG_INFO, LD_DIR,
+      "Reloaded microdescriptor cache. Found %d descriptors.", total);

but then I noticed that 0.2.2.38 doesn't have a line about loading descriptors, so I have tentatively marked this as 0.2.3.x-final and suggest just downgrading the log message.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking