Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #681

Closed (moved)
Open
Opened May 08, 2008 by Roger Dingledine@arma

encrypted dir conns confuse LeaveStreamsUnattached

(This is Mikeperry's bug)

When we launch an encrypted dir conn in directory.c via connection_ap_make_link(), it'll put the stream in state AP_CONN_STATE_CIRCUIT_WAIT. This means that even controllers that set LeaveStreamsUnattached won't need to handle it, since it's already being handled.

Bug #1: controllers don't know this, and can't distinguish streams that are already being handled. Mike had a patch to put an extra flag on the stream status line.

Bug #2 (closed): then if the stream causes a circuit to get created, and gets attached to that circuit, but the circuit times out or otherwise fails to fulfill the request, the stream will be handled by connection_ap_detach_retriable() which will set it to state AP_CONN_STATE_CONTROLLER_WAIT. And the controller doesn't realize that this time it's supposed to handle it (and it probably shouldn't need to handle it)

[Automatically added by flyspray2trac: Operating System: All]

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
0.2.0.x-final
Milestone
0.2.0.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#681