Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #6833

Closed (moved)
(moved)
Open
Created Sep 13, 2012 by Nick Mathewson@nickm🍬

Tor authorities don't handle votes with more than 64 known-flags

When we get more than 64 known-flags in a vote, we try to stuff them all in an uint64 anyway, and access them by masking with 1<<flagnum. That's undefined behavior right there.

For now, authorities should refuse to accept any vote with more than 64 flags. (We're not even close to that limit right now.) Later, we can use a bitfield instead or something.

This is only a vote issue. Consensus parsing doesn't have this problem, since we just look for the flags we recognize when we're parsing a consensus.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking