Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #6875

Closed (moved)
Open
Opened Sep 17, 2012 by grarpamp@grarpamp

Documentation fixes: base-{16,32,64}

Typos and other such trivialities...

Whereas the other mentions (being the majority) in the code and spec trees use the non-hyphenated 'baseXX' form, these mentions need their hyphens removed for consistancy and grepability

tor/src/common/crypto.h:258:/** Characters that can appear (case-insensitively) in a base-32 encoding. / tor/src/or/rendcommon.c:957:/* query is a base-32'ed service id. If it's malformed, return -1. torspec/rend-spec.txt:348: The identifier of this introduction point: the base-32 encoded torspec/rend-spec.txt:529: hostname of the form "z.onion", where z is a base-32 encoding of a

tor/src/common/crypto.c:2520:/** Base-64 encode srclen bytes of data from src. Write tor/src/common/crypto.c:2579:/** Base-64 decode srclen bytes of data from src. Write tor/src/common/crypto.c:2686:/** Base-64 encode DIGEST_LINE bytes from digest, remove the trailing = tor/src/common/crypto.c:2699:/** Given a base-64 encoded, nul-terminated digest in d64 (without tor/src/common/crypto.c:2724:/** Base-64 encode DIGEST256_LINE bytes from digest, remove the tor/src/common/crypto.c:2737:/** Given a base-64 encoded, nul-terminated digest in d64 (without torspec/attic/dir-spec-v1.txt:50: Object ::= BeginLine Base-64-encoded-data EndLine torspec/dir-spec-v2.txt:105: Object ::= BeginLine Base-64-encoded-data EndLine torspec/dir-spec.txt:226: Object ::= BeginLine Base-64-encoded-data EndLine torspec/dir-spec.txt:2327: are base-64 encoded with trailing =s omitted for size and for torspec/proposals/128-bridge-families.txt:56: where %s is the base-64 bridge password. torspec/proposals/154-automatic-updates.txt:119: Object ::= BeginLine Base-64-encoded-data EndLine torspec/proposals/ideas/xxx-new-crypto-sketch.txt:302: use the notation %b64, where b64 is a base-64 encoding, omitting the torspec/proposals/ideas/xxx-new-crypto-sketch.txt:308: Since 43 base-64 characters is enough to represent a 256-bit digest,

torspec/dir-spec-v2.txt:555: "Fingerprints" in these URLs are base-16-encoded SHA1 hashes. torspec/dir-spec.txt:2362: "Fingerprints" in these URLs are base-16-encoded SHA1 hashes.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.2.4.x-final
Milestone
Tor: 0.2.4.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#6875