Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #7014

Closed (moved)
(moved)
Open
Created Oct 02, 2012 by David Fifield@dcf

fmt_addr used more than once in parameter lists

fmt_addr is called twice as an argument to log_notice, in two places in transport_resolve_conflicts. Maybe other places too. Because fmt_addr writes to a static buffer, one call clobbers the result of the other.

With this torrc,

ClientTransportPlugin dummy socks4 1.1.1.1:10001
ClientTransportPlugin dummy socks4 2.2.2.2:10001
Log "notice stderr"

you get the log (observe wrongly repeated address)

[notice] You tried to add transport 'dummy' at '2.2.2.2:10001' but the same transport already exists at '2.2.2.2:10001'. Skipping.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking