Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #7295

Closed
Open
Opened Nov 03, 2012 by Arturo Filasto@art

Core tests are broken

Something after commit c12bc4d89ef16d78e2cf2ef22363802ec90022ae broke the core tests.

I believe it has something to do with the changes that have been made to runner.py.

Here is a list of things that I noticed that may or may not be related to this issue, but that are for sure not good practice (this is all related to ooni/runner.py):

There is code duplication in processTest(obj, config) and processTestOptions. Looking around processTest appears to no longer be called.

loadTestsAndOptions has become a huge method. I would consider splitting the things that have to do with the legacy API to another place.

The uber deep nesting plague appears to have started to attack parts of the code. In particular https://gitweb.torproject.org/ooni-probe.git/blob/HEAD:/ooni/runner.py#l200, https://gitweb.torproject.org/ooni-probe.git/blob/HEAD:/ooni/runner.py#l238, https://gitweb.torproject.org/ooni-probe.git/blob/HEAD:/ooni/runner.py#l258

If you start nesting beyond one level, you should ask yourself if there is a better way to write it.

We should also not spend any more time on supporting the old API. Every line of code we write to support it is a line of code we have to maintain, that is bad.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#7295