Skip to content

GitLab

Trac
Trac

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by Damian Johnson@atagar

Better definition for ADDRMAP events

The ADDRMAP specification is making me twitch for a few reasons...

  • It doesn't say what the events do. My guess from seeing a few is that it simply indicates DNS resolution. However, the spec doesn't make this clear and it allows hostnames to be resolved to other hostnames (I'm guessing that is a mistake).

  • The errors are undefined. An 'XXXX' is pretty bad - I hope we can at least say what the error code can include.

  • The spec summary has some mistakes. For instance, it doen't list GMTExpiry as being optional (despite saying so below), and it should make it clear that 'error' and 'GMTExpiry' are key/value entries. My first thought when I saw this event was "WTF? They have an optional positional argument?!? Gah!"

Patch is available in my 'addrmap' branch... https://gitweb.torproject.org/user/atagar/torspec.git/commitdiff/0168f7d58aaf4d8d840407f1b3420218ee2d3eeb

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information