Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #7669

Closed (moved)
(moved)
Open
Created Dec 08, 2012 by Trac@tracbot

SIZEOF_INTPTR_T not defined in msvc builds

Change 1bfda600 added a block of helper code to src/common/compat.h that assumes SIZEOF_INTPTR_T is defined. While this is the case for configure-driven builds (defines available since 2004), for the prepared win32 config the define is nowhere to be found. This causes a compilation error.

I looked and saw that torint.h introduces type intptr_t when HAVE_INTPTR_T is not present. Also, it does #if (SIZEOF_INTPTR_T != 0) #define HAVE_INTPTR_T, so just defining it in orconfig.h would actually break this code. My first guess is that torint.h should define the sizeof at the moment it adds the intptr_t typedef. There might be better solutions.

PS: uintptr_t should be dealt with as well.

Trac:
Username: ultramage

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking