Skip to content

GitLab

Trac
Trac

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by Nick Mathewson@nickm🥄

Reading pending TLS bytes can take us over at_most

In connection_read_to_buf(), after we fetch pending TLS bytes, we re-set 'result' to be the total number of bytes actually read. But later we do:

  if (more_to_read && result == at_most) {
    slack_in_buf = buf_slack(conn->inbuf);
    at_most = more_to_read;
    goto again;
  }

That's not good; 'result' can also be >= at_most, which might also mean that we should try reading more, maybe.

Reported pseudonymously; the reporter attached this patch. Possibly backportable to 0.2.3.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information