GitLab

Damian,

I looked more closely at the various authentication paths after your email0. And I concluded, I still don't like the hook in BaseController.msg. 8-)

This patch set1 is my second attempt to find an alternative approach. Basically, call _post_authentication() at the end of each connection.authentication* function. This covers 2 of the 3 use cases you presented.

If someone goes to the trouble to hand-compose an AUTHENTICATE message string to send through BC.msg, they should be sophisticated enough to re-attach event listeners on their own. Someone reaching that deeply into the abstraction layer can protect themselves.

This is my last, best argument for moving the hook. I respect your decision either way.

Trac:
Username: robinson