Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #8059

Closed (moved)
(moved)
Open
Created Jan 26, 2013 by Roger Dingledine@arma

miscounting when parsing versions cell

  const uint8_t *cp, *end;
...
  for (cp = cell->payload; cp+1 < end; ++cp) {
    uint16_t v = ntohs(get_uint16(cp));

So we count the payload one byte at a time, considering that byte plus the one after it?

The payload in a VERSIONS cell is a series of big-endian two-byte
   integers.

That probably produces some weird behavior. Marking as 0.2.3 since I'm not sure yet what weird behavior.

Reported by bob from irc.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking