ooni: NetTestCase.checkRequiredOptions() does not parse conditionals
if i do:
class FooTestCase(nettest.NetTestCase):
checkRequiredOptions = ['dstip', 'port']
everything works just fine, because checkRequiredOptions() expects a list of things that are expected, and if anything is missing then it doesn't run FooTestCase.
However, what if I wanted to do:
class FooTestCase(nettest.NetTestCase):
checkRequiredOptions = ( 'dstip' & 'port' ) || 'file'
Obviously, doesn't work. But it should, because there are now several tests which essentially have their own smarter versions of checkRequiredOptions(), including dnsconsistency and echo.
In the newer (as of right now unmerged) feature/task-manager* branches, either NetTestCase.checkRequiredOptions() or NetTestLoader.checkOptions() should support conditional options (the latter has a call to the former).