Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #8652

Closed (moved)
Open
Opened Apr 06, 2013 by Trac@tracbot

[patch] Google Maps local_url exclusion

Clicking on a link in Google Maps which starts with http://maps.google.com/local_url gets redirected to the https version, which results in an error 400 from Google. This patch fixes the ruleset. Patch also attached as a file.

From e1c5af6dba40ebf3718763518e6d6ce555603f85 Mon Sep 17 00:00:00 2001
From: Kenyon Ralph <kenyon@kenyonralph.com>
Date: Fri, 5 Apr 2013 22:49:52 -0700
Subject: [PATCH] [GoogleMaps] exclude http://maps.google.com/local_url

These URLs return error 400 if rewritten to https, so exclude them.
---
 src/chrome/content/rules/GoogleMaps.xml |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/chrome/content/rules/GoogleMaps.xml b/src/chrome/content/rules/GoogleMaps.xml
index e04bb60..c7afc7b 100644
--- a/src/chrome/content/rules/GoogleMaps.xml
+++ b/src/chrome/content/rules/GoogleMaps.xml
@@ -11,6 +11,8 @@
 							-->
 		<exclusion pattern="^http://maps\.googleapis\.com/map(?:files/lib/map_1_20\.swf|sapi/publicapi\?file=flashapi)" />
 		<exclusion pattern="^http://maps\.google\.gr/transitathens" />
+		<exclusion pattern="^http://maps\.google\.com/local_url" />
+
 	<target host="maps.gstatic.com" />
 
 
@@ -31,4 +33,4 @@
 	<rule from="^https://maps\.googleapis\.com/map(files/lib/map_1_20\.swf|sapi/publicapi\?file=flashapi)"
 		to="http://maps.googleapis.com/map$1" downgrade="1" />
 
-</ruleset>
\ No newline at end of file
+</ruleset>
-- 
1.7.10.4

Trac:
Username: kenyon

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
HTTPS-E 3.2
Milestone
HTTPS-E 3.2
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#8652