GitLab

In #6752 (moved), I noticed a troublesome point about some of our Testing* options. The convention is that these options can only take a non-default value when TestingTorNetwork is set. So we might have something like:

   TestingBeVerySecure 0

to mean that we should turn off the security feature "BeVerySecure", and that this is an option you can only set when TestingTorNetwork is enabled.

But the trouble happens when you go to read the code and you see something like

   if (options->TestingBeVerySecure) {
     ....
   }

which gives the impression that the block will only be executed when some kind of Testing feature is enabled, which is not the case.

I think we need a better convention here.