Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #9024

Closed (moved)
Open
Opened Jun 05, 2013 by Trac@tracbot

add supplementary groups when changing uid

Under Android, it's important to be in group 3003 to access the network. Current tor code switch_id() in common/compat.c only sets the primary group. That means that tor and everything like /var/run/tor has to be in group 3003.

It'd be nice to leave /var/run/tor owned by group debian-tor. That means to access the network, 3003 has to be a supplementary group for user debian-tor (easy) and switch_id() has to call setgroups() on the entire supplementary groups list.

There might be other security issues with doing this that I'm not aware of.

Trac:
Username: baccala

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#9024