Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #9564

Closed (moved)
Open
Opened Aug 22, 2013 by Nick Mathewson@nickm🥄

Bogus "return" in update_consensus_networkstatus_downloads()

In update_consensus_networkstatus_downloads(), we consider, flavor-by-flavor, which networkstatus documents if any to download. If we decide not to download one, we should use "continue" to consider the next. Instead, in one place, we use return:

    if (time_to_download_next_consensus[i] > now)
      return; /* Wait until the current consensus is older. */

This can prevent a directory cache from fetching microdescriptor consensuses in a sufficiently timely way.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.2.4.x-final
Milestone
Tor: 0.2.4.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#9564