Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #959

Closed (moved)
Open
Opened Mar 27, 2009 by Roger Dingledine@arma

bodylen 501408 larger than 499999. Failing.

Tor directory authorities are refusing uploaded votes, since the votes have grown larger than 500KB.

Mar 26 23:50:03.015 [warn] bodylen 501408 larger than 499999. Failing. Mar 26 23:50:03.015 [warn] Invalid input from address '86.59.21.38'. Closing.

moria1 (and others) have been doing this for the past 5 days, and the world hasn't exploded. I think that's because the uploads are refused:

/** Maximum size, in bytes, for any directory object that we're accepting

  • as an upload. */ #define MAX_DIR_UL_SIZE 500000

but then Tor falls back to fetching the votes, which succeeds: /** Maximum size, in bytes, for any directory object that we've downloaded. */ #define MAX_DIR_DL_SIZE MAX_BUF_SIZE

Currently there are only four items that are uploaded: /** A connection to a directory server: upload a server descriptor. / #define DIR_PURPOSE_UPLOAD_DIR 8 /* A connection to a directory server: upload a rendezvous

  • descriptor. / #define DIR_PURPOSE_UPLOAD_RENDDESC 9 /* A connection to a directory server: upload a v3 networkstatus vote. / #define DIR_PURPOSE_UPLOAD_VOTE 10 /* A connection to a directory server: upload a v3 consensus signature */ #define DIR_PURPOSE_UPLOAD_SIGNATURES 11

And once UPLOAD_DIR has finished, we limit the size of the objects we're willing to add, in case we're attacked.

I think the right fix is to set MAX_DIR_UL_SIZE to MAX_BUF_SIZE also. Any other fix will mean we reopen this bug in 18 months.

[Automatically added by flyspray2trac: Operating System: All]

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#959