Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #9980

Closed (moved)
(moved)
Open
Created Oct 14, 2013 by Nick Mathewson@nickm🍬

(cp >= end) in channel_tls_process_netinfo_cell confuses analysis tools

David Fifield reports that:

  my_addr_len = (uint8_t) cell->payload[5];
  end = cell->payload + CELL_PAYLOAD_SIZE;
  cp = cell->payload + 6 + my_addr_len;
  if (cp >= end) {
    ...
    return;
  }

confuses the STACK analysis tool because the check could get optimized away. This check is indeed needless, since CELL_PAYLOAD_SIZE is 509, but UINT8_MAX + 6 is only 261, so that branch can never be taken. Shall we just remove it?

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking