Loading src/or/connection.c +8 −1 Original line number Diff line number Diff line Loading @@ -1860,9 +1860,16 @@ loop_again: /* The other side's handle_write will never actually get called, so * we need to invoke the appropriate callbacks ourself. */ connection_t *linked = conn->linked_conn; /* XXXX020rc Do we need to ensure that this stuff is called even if /* XXXX020 Do we need to ensure that this stuff is called even if * conn dies in a way that causes us to return -1 earlier? -NM * No idea. -RD */ /* Actually, I'm pretty sure not. The big things here are to * tell the linked connection, "yes, you wrote some stuff!" so that * it can succeed as a appropriate. But if this side of the link * returned -1, then it couldn't process the data it got. That's * fairly rare, and doesn't really count as "success" for the other * side. -NM */ if (n_read) { /* Probably a no-op, but hey. */ Loading Loading
src/or/connection.c +8 −1 Original line number Diff line number Diff line Loading @@ -1860,9 +1860,16 @@ loop_again: /* The other side's handle_write will never actually get called, so * we need to invoke the appropriate callbacks ourself. */ connection_t *linked = conn->linked_conn; /* XXXX020rc Do we need to ensure that this stuff is called even if /* XXXX020 Do we need to ensure that this stuff is called even if * conn dies in a way that causes us to return -1 earlier? -NM * No idea. -RD */ /* Actually, I'm pretty sure not. The big things here are to * tell the linked connection, "yes, you wrote some stuff!" so that * it can succeed as a appropriate. But if this side of the link * returned -1, then it couldn't process the data it got. That's * fairly rare, and doesn't really count as "success" for the other * side. -NM */ if (n_read) { /* Probably a no-op, but hey. */ Loading
