Commit 23fdfd4d authored by Roger Dingledine's avatar Roger Dingledine
Browse files

Stop leaking conn->nickname every time we make a connection to a 

Tor relay without knowing its expected identity digest (e.g. when
using bridges). Bugfix on 0.2.0.3-alpha.


svn:r12355
parent 512abd5b

ChangeLog

+3 −0
Original line number Diff line number Diff line
@@ -75,6 +75,9 @@ Changes in version 0.2.0.10-alpha - 2007-1?-?? 
      a vote.  Bugfix on 0.2.0.3-alpha.

    - Stop leaking v2_download_status_map on shutdown.  Bugfix on

      0.2.0.9-alpha.

    - Stop leaking conn->nickname every time we make a connection to a

      Tor relay without knowing its expected identity digest (e.g. when

      using bridges). Bugfix on 0.2.0.3-alpha.



  - Minor bugfixes (portability):

    - Run correctly on platforms where rlim_t is larger than unsigned

src/or/connection_or.c

+1 −0
Original line number Diff line number Diff line
@@ -663,6 +663,7 @@ connection_or_check_valid_handshake(or_connection_t *conn, int started_here, 


  if (started_here && tor_digest_is_zero(conn->identity_digest)) {

    memcpy(conn->identity_digest, digest_rcvd, DIGEST_LEN);

    tor_free(conn->nickname);

    conn->nickname = tor_malloc(HEX_DIGEST_LEN+2);

    conn->nickname[0] = '$';

    base16_encode(conn->nickname+1, HEX_DIGEST_LEN+1,