Commit 24aae484 authored by Nick Mathewson's avatar Nick Mathewson 🦀
Browse files

r17624@catbus: nickm | 2008-01-15 00:42:01 -0500 

 Fixes to more anonymously-reported typos and logic errors.


svn:r13136
parent a9840118

ChangeLog

+8 −0
Original line number Diff line number Diff line
@@ -50,6 +50,14 @@ Changes in version 0.2.0.16-alpha - 2008-01-?? 
    - Avoid segfault in the case where a badly behaved v2 versioning

      directory sends a signed networkstatus with missing client-versions.

      Bugfix on 0.1.2.

    - Avoid segfaults on certain complex invocations of

      router_get_by_hexdigest().  Bugfix on 0.1.2.

    - Correct bad index on array access in parse_http_time().  Bugfix

      on 0.2.0.

    - Fix possible bug in vote generation when server versions are present

      but client versions are not.

    - Fix rare bug on REDIRECTSTREAM control command when called with no

      port set: it could erroneously report an error when none had happened.



  o Minor features (controller):

    - Get NS events working again.  (Patch from tup)

src/common/util.c

+1 −1
Original line number Diff line number Diff line
@@ -1271,7 +1271,7 @@ parse_http_time(const char *date, struct tm *tm) 
    }

  }



  month[4] = '\0';

  month[3] = '\0';

  /* Okay, now decode the month. */

  for (i = 0; i < 12; ++i) {

    if (!strcasecmp(MONTH_NAMES[i], month)) {

src/or/connection_edge.c

+1 −0
Original line number Diff line number Diff line
@@ -2304,6 +2304,7 @@ connection_exit_begin_conn(cell_t *cell, circuit_t *circ) 
      address = tor_strdup(or_circ->p_conn->_base.address);

    else

      address = tor_strdup("127.0.0.1");

    port = 1; /*XXXX020 set this to something sensible?  - NM*/

  } else {

    log_warn(LD_BUG, "Got an unexpected command %d", (int)rh.command);

    end_payload[0] = END_STREAM_REASON_INTERNAL;

src/or/control.c

+1 −1
Original line number Diff line number Diff line
@@ -2325,7 +2325,7 @@ handle_control_redirectstream(control_connection_t *conn, uint32_t len, 
    connection_printf_to_buf(conn, "552 Unknown stream \"%s\"\r\n",

                             (char*)smartlist_get(args, 0));

  } else {

    int ok;

    int ok = 1;

    if (smartlist_len(args) > 2) { /* they included a port too */

      new_port = (uint16_t) tor_parse_ulong(smartlist_get(args, 2),

                                            10, 1, 65535, &ok, NULL);

src/or/dirvote.c

+1 −1
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ format_networkstatus_vote(crypto_pk_env_t *private_signing_key, 
    char *cp;

    if (client_versions)

      v_len += strlen(client_versions);

    if (client_versions)

    if (server_versions)

      v_len += strlen(server_versions);

    version_lines = tor_malloc(v_len);

    cp = version_lines;