Commit 7b4716a7 authored by Nick Mathewson's avatar Nick Mathewson 👜
Browse files

Make test_glob() pass even when run as root.

Previously the test relied on not being able to look inside 000
directories, which is a thing root _can_ do.

Bug not in any released Tor version.
parent effc9739
......@@ -4622,11 +4622,14 @@ test_util_glob(void *ptr)
TEST("\\*");
EXPECT_EMPTY();
// test forbidden directory
tor_asprintf(&pattern, "%s"PATH_SEPARATOR"*"PATH_SEPARATOR"*", dirname);
results = tor_glob(pattern);
tor_free(pattern);
tt_assert(!results);
if (getuid() != 0) {
// test forbidden directory, if we're not root.
// (Root will be able to see this directory anyway.)
tor_asprintf(&pattern, "%s"PATH_SEPARATOR"*"PATH_SEPARATOR"*", dirname);
results = tor_glob(pattern);
tor_free(pattern);
tt_assert(!results);
}
#endif
#undef TEST
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment