Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Mike Perry
Tor
Commits
9316ca9f
Commit
9316ca9f
authored
Aug 11, 2020
by
George Kadianakis
Browse files
Remove a BUG() that could normally trigger in edge-cases.
parent
18d2c7c5
Changes
2
Hide whitespace changes
Inline
Side-by-side
changes/bug34086
0 → 100644
View file @
9316ca9f
o Minor bugfixes (onion service v3):
- Remove a BUG() warning that could trigger in certain unlikely edge-cases.
Fixes bug 34086; bugfix on 0.3.2.1-alpha.
src/feature/hs/hs_client.c
View file @
9316ca9f
...
@@ -778,10 +778,16 @@ client_rendezvous_circ_has_opened(origin_circuit_t *circ)
...
@@ -778,10 +778,16 @@ client_rendezvous_circ_has_opened(origin_circuit_t *circ)
* the v3 rendezvous protocol */
* the v3 rendezvous protocol */
if
(
rp_ei
)
{
if
(
rp_ei
)
{
const
node_t
*
rp_node
=
node_get_by_id
(
rp_ei
->
identity_digest
);
const
node_t
*
rp_node
=
node_get_by_id
(
rp_ei
->
identity_digest
);
if
(
rp_node
)
{
if
(
rp_node
&&
!
node_supports_v3_rendezvous_point
(
rp_node
))
{
if
(
BUG
(
!
node_supports_v3_rendezvous_point
(
rp_node
)))
{
/* Even tho we checked that this node supported v3 when we created the
return
;
rendezvous circuit, there is a chance that we might think it does
}
not support v3 anymore. This might happen if we got a new consensus
in the meanwhile, where the relay is still listed but its listed
descriptor digest has changed and hence we can't access its 'ri' or
'md'. */
log_info
(
LD_REND
,
"Rendezvous node %s did not support v3 after circuit "
"has opened."
,
safe_str_client
(
extend_info_describe
(
rp_ei
)));
return
;
}
}
}
}
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment