Commit d073d7d4 authored by Nick Mathewson's avatar Nick Mathewson 🐚
Browse files

Consistency issues in load_windows_system_library patch. Thanks Sebastian

parent aa7f55c4

src/common/util.c

+1 −1
Original line number Diff line number Diff line
@@ -2800,7 +2800,7 @@ load_windows_system_library(const TCHAR *library_name) 
{

  TCHAR path[MAX_PATH];

  unsigned n;

  n = GetSystemDirectory(path, 1024);

  n = GetSystemDirectory(path, MAX_PATH);

  if (n == 0 || n + _tcslen(library_name) + 2 >= MAX_PATH)

    return 0;

  _tcscat(path, TEXT("\\"));

src/or/eventdns.c

+0 −1
Original line number Diff line number Diff line
@@ -3131,7 +3131,6 @@ load_nameservers_with_getnetworkparams(void) 
	IP_ADDR_STRING *ns;

	GetNetworkParams_fn_t fn;



	/* XXXX Possibly, we should hardcode the location of this DLL. */

	if (!(handle = load_windows_system_library(TEXT("iphlpapi.dll")))) {

		log(EVDNS_LOG_WARN, "Could not open iphlpapi.dll");

		/* right now status = 0, doesn't that mean "good" - mikec */

src/or/ntmain.c

+0 −1
Original line number Diff line number Diff line
@@ -138,7 +138,6 @@ nt_service_loadlibrary(void) 
  if (service_fns.loaded)

    return;



  /* XXXX Possibly, we should hardcode the location of this DLL. */

  if (!(library = load_windows_system_library(TEXT("advapi32.dll")))) {

    log_err(LD_GENERAL, "Couldn't open advapi32.dll.  Are you trying to use "

            "NT services on Windows 98? That doesn't work.");