They are about to be shutdown in September.
Signed-off-by: David Goulet <dgoulet@torproject.org>

David Goulet authored Jul 23, 2020 and Nick Mathewson committed Jul 23, 2020

Closes #40061

Signed-off-by: David Goulet <dgoulet@torproject.org>

GCC added an implicit-fallthrough warning a while back, where it
would complain if you had a nontrivial "case:" block that didn't end
with break, return, or something like that.  Clang recently added
the same thing.

GCC, however, would let you annotate a fall-through as intended by
any of various magic "/* fall through */" comments.  Clang, however,
only seems to like "__attribute__((fallthrough))".  Fortunately, GCC
accepts that too.

A previous commit in this branch defined a FALLTHROUGH macro to do
the right thing if GNUC is defined; here we replace all of our "fall
through" comments with uses of that macro.

This is an automated commit, made with the following perl one-liner:

  #!/usr/bin/perl -i -p
  s#/\* *falls? ?thr.*?\*/#FALLTHROUGH;#i;

David Goulet authored Feb 18, 2020 and Nick Mathewson committed Mar 12, 2020

Closes #33361
Signed-off-by: David Goulet <dgoulet@torproject.org>

Alexander Færøy authored Jan 15, 2020 and teor committed Feb 12, 2020

This patch ensures that we always lowercase the BridgeDistribution from
torrc in descriptors before submitting it.

See: https://bugs.torproject.org/32753

Fixes bug 30894; bugfix on 0.3.4.1-alpha

Otherwise, we won't realize that we haven't got enough bridge
information to build circuits.  Part of a fix for ticket 29875.

Fixes bug 22619; bugfix on 0.2.7.2-alpha

Closes ticket 30452.

We add an option param to safe_str and safe_str_client because in
some case we need to use those functions before global_options is set.

Kris Katterjohn authored Dec 23, 2018 and Nick Mathewson committed Jan 09, 2019

Prior to this commit, the testsuite was failing on OpenBSD.  After
this commit the testsuite runs fine on OpenBSD.

It was previously decided to test for the OpenBSD macro (rather than
__OpenBSD__, etc.) because OpenBSD forks seem to have the former
macro defined.  sys/param.h must be included for the OpenBSD macro
definition; however, many files tested for the OpenBSD macro without
having this header included.

This commit includes sys/param.h in the files where the OpenBSD macro
is used (and sys/param.h is not already included), and it also
changes some instances of the __OpenBSD__ macro to OpenBSD.

See commit 27df23ab

 which changed
everything to use OpenBSD instead of __OpenBSD__ or OPENBSD.  See
also tickets #6982 and #20980 (the latter ticket is where it was
decided to use the OpenBSD macro).
Signed-off-by: Kris Katterjohn <katterjohn@gmail.com>

Fixes bug 28612; bugfix on 0.3.5.3-alpha.

It was always analyzed before use, but scan-build wasn't able to
persuade itself of that.

Closes ticket 28881.

It was disabled-by-default for ages, and it no longer compiles. I
think it's safe to call it obsolete.

When freeing a configuration object from confparse.c in
dump_config(), we need to call the appropriate higher-level free
function (like or_options_free()) and not just config_free().

This only happens with options (since they're the one where
options_validate allocates extra stuff) and only when running
--dump-config with something other than minimal (since
OPTIONS_DUMP_MINIMAL doesn't hit this code).

Fixes bug 27893; bugfix on 0.3.2.1-alpha.

This commit just moves the code to two separate files. The geoip
code still has a few needless dependencies on core/* and features/*.

It differs from the rest of the rephist code in that it's actually
necessary for Tor to operate, so it should probably go somewhere
else.  I'm not sure where yet, so I'll leave it in the same
directory, but give it its own file.

Make them only include the headers that they needed, and sort their
headers while we're at it.

This is preparation for having a routermode.h as well

Fixes a stem test failure; bugfix on c7ce6b98. Bug
not in any released Tor.

The main.c code is responsible for initialization and shutdown;
the mainloop.c code is responsible for running the main loop of Tor.

Splitting the "generic event loop" part of mainloop.c from the
event-loop-specific part is not done as part of this patch.

In dirauth:
  * bwauth.c reads and uses bandwidth files
  * guardfraction.c reads and uses the guardfraction file
  * reachability.c tests relay reachability
  * recommend_pkg.c handles the recommended-packages lines.
  * recv_descs.c handles fingerprint files and processing incoming
    routerinfos that relays upload to us
  * voteflag.c computes flag thresholds and sets those thresholds on
    routerstatuses when computing votes

In control:
  * fmt_serverstatus.c generates the ancient "v1 server status"
    format that controllers expect.

In nodelist:
  * routerstatus_fmt.c formats routerstatus entries for a consensus,
    a vote, or for the controller.

There are now separate modules for:
    * the list of router descriptors
    * the list of authorities and fallbacks
    * managing authority certificates
    * selecting random nodes

Moves code to a function, better viewed with --color-moved.

Without this, RunAsDaemon breaks NSS.

Fixes bug 27664; bug not in any released Tor.

(a relay operator hit this on #tor-relays and couldn't make sense
of it. i couldn't either until i went to go read the code.)

haxxpop authored Aug 19, 2018 and David Goulet committed Sep 07, 2018

The new ClientOnionAuthDir option is introduced which is where tor looks to
find the HS v3 client authorization files containing the client private key
material.
Signed-off-by: David Goulet <dgoulet@torproject.org>

Closes ticket #27428.

David Goulet authored Jul 09, 2018 and Nick Mathewson committed Aug 28, 2018

Remove support for Tor2web in the code and build system. At this commit, tor
doesn't have Tor2web support anymore.

Ref: https://lists.torproject.org/pipermail/tor-dev/2018-July/013295.html



Close #26367
Signed-off-by: David Goulet <dgoulet@torproject.org>

Since 0.3.3.5-rc, authorities require DirCache (V2Dir) for the Guard
flag.

Fixes bug 24312; bugfix on 0.3.3.5-rc.