shouldn't actually change anything, but who knows.

In C, the code "char x[10]; if (x) {...}" always takes the true branch of
the if statement.  Coverity notices this now.

In some cases, we were testing arrays to make sure that an operation
we wanted to do would suceed.  Those cases are now always-true.

In some cases, we were testing arrays to see if something was _set_.
Those caes are now tests for strlen(s), or tests for
!tor_mem_is_zero(d,len).

i think this doesn't actually affect anything, since linked
conns usually don't impact buckets

Changes to directory request statistics:

- Rename GEOIP statistics to DIRREQ statistics, because they now include
  more than only GeoIP-based statistics, whereas other statistics are
  GeoIP-dependent, too.
- Rename output file from geoip-stats to dirreq-stats.
- Add new config option DirReqStatistics that is required to measure
  directory request statistics.
- Clean up ChangeLog.

Also ensure that entry guards statistics have access to a local GeoIP
database.

- Use common prefixes DIRREQ_* and dirreq_*.
- Replace enums in structs with bitfields.

Karsten Loesing authored Jun 24, 2009 and Nick Mathewson committed Jul 02, 2009

[Original patch series from Karsten, revised and squashed by Nick]

Christopher Davis authored Jun 18, 2009 and Nick Mathewson committed Jun 19, 2009

Added a sanity check in config.c and a check in directory.c
directory_initiate_command_rend() to catch any direct connection attempts
when a socks proxy is configured.

The rest of the code was only including event.h so that it could see
EV_READ and EV_WRITE, which we were using as part of the
connection_watch_events interface for no very good reason.

to forgive our bridges and try again when we get an application
request. Bugfix on 0.2.0.x.


svn:r18396

The subversion $Id$ fields made every commit force a rebuild of
whatever file got committed.  They were not actually useful for
telling the version of Tor files in the wild.

svn:r17867

svn:r17823

svn:r17820

svn:r17799

Make connection_create_listener take a sockaddr_len, not just a sockaddr whose length we try to divine.

svn:r17792

Add more missing documentation, and correct an error in container.c documentation: Don't introduce two parameters called n when you're calling an algorithm O(n).

svn:r17783

svn:r17739

svn:r17734

Add DOCDOC comments for all undocumented functions.  Add missing *s to other comments so that they will get recognized as doxygen.

svn:r17729

Replace calls to time(NULL) that occur on the order of once per read, one per write, or once per cell with calls to a function that looks at a cached value of time.  This is tricksy to benchmark, since it will only help on systems where time() is a syscall and syscalls are relatively slow.

svn:r17690

svn:r17686

(The unfixed ones are being downgraded to regular XXXs mainly on the rationale that they don't seem to be exploding Tor, and they were apparently not showstoppers for 0.2.0.x-final.)

svn:r17682

svn:r17643

Now that tor_assert is no longer using a broken force-to-boolean formulation, we can tor_assert a bitfield without a gcc compile error.

svn:r17598

svn:r16975

Add patch 4 from Karsten for proposal 121, slightly modified.  Karsten should definitely re-review the bits I changed.

svn:r16955

svn:r16916