1. 30 Jun, 2016 2 commits
  2. 20 Jun, 2016 1 commit
  3. 11 Jun, 2016 3 commits
    • Nick Mathewson's avatar
      Add -Wmissing-variable-declarations, with attendant fixes · 53a3b39d
      Nick Mathewson authored
      This is a big-ish patch, but it's very straightforward.  Under this
      clang warning, we're not actually allowed to have a global variable
      without a previous extern declaration for it.  The cases where we
      violated this rule fall into three roughly equal groups:
        * Stuff that should have been static.
        * Stuff that was global but where the extern was local to some
          other C file.
        * Stuff that was only global when built for the unit tests, that
          needed a conditional extern in the headers.
      
      The first two were IMO genuine problems; the last is a wart of how
      we build tests.
      53a3b39d
    • Nick Mathewson's avatar
      Use autoconf, not gcc version, to decide which warnings we have · 9bbd6502
      Nick Mathewson authored
      This gives more accurate results under Clang, which can only help us
      detect more warnings in more places.
      
      Fixes bug 19216; bugfix on 0.2.0.1-alpha
      9bbd6502
    • Nick Mathewson's avatar
      Add -Wfloat-conversion for GCC >= 4.9 · 493499a3
      Nick Mathewson authored
      This caught quite a few minor issues in our unit tests and elsewhere
      in our code.
      493499a3
  4. 30 May, 2016 1 commit
    • Nick Mathewson's avatar
      Replace nearly all XXX0vv comments with smarter ones · 4f1a04ff
      Nick Mathewson authored
      So, back long ago, XXX012 meant, "before Tor 0.1.2 is released, we
      had better revisit this comment and fix it!"
      
      But we have a huge pile of such comments accumulated for a large
      number of released versions!  Not cool.
      
      So, here's what I tried to do:
      
        * 0.2.9 and 0.2.8 are retained, since those are not yet released.
      
        * XXX+ or XXX++ or XXX++++ or whatever means, "This one looks
          quite important!"
      
        * The others, after one-by-one examination, are downgraded to
          plain old XXX.  Which doesn't mean they aren't a problem -- just
          that they cannot possibly be a release-blocking problem.
      4f1a04ff
  5. 28 Apr, 2016 2 commits
  6. 07 Apr, 2016 2 commits
  7. 15 Mar, 2016 2 commits
  8. 14 Mar, 2016 1 commit
  9. 11 Mar, 2016 2 commits
  10. 01 Mar, 2016 1 commit
  11. 27 Feb, 2016 1 commit
  12. 22 Feb, 2016 1 commit
  13. 12 Feb, 2016 1 commit
  14. 28 Jan, 2016 3 commits
  15. 26 Jan, 2016 1 commit
  16. 08 Jan, 2016 1 commit
  17. 07 Jan, 2016 1 commit
  18. 06 Jan, 2016 1 commit
  19. 22 Dec, 2015 1 commit
  20. 21 Dec, 2015 2 commits
  21. 18 Dec, 2015 2 commits
  22. 15 Dec, 2015 5 commits
    • teor's avatar
      Add Fallback Directory Candidate Selection Script · 4c1c2a31
      teor authored
      "Tor has included a feature to fetch the initial consensus from nodes
       other than the authorities for a while now. We just haven't shipped a
       list of alternate locations for clients to go to yet.
      
       Reasons why we might want to ship tor with a list of additional places
       where clients can find the consensus is that it makes authority
       reachability and BW less important.
      
       We want them to have been around and using their current key, address,
       and port for a while now (120 days), and have been running, a guard,
       and a v2 directory mirror for most of that time."
      
      Features:
      * whitelist and blacklist for an opt-in/opt-out trial.
      * excludes BadExits, tor versions that aren't recommended, and low
        consensus weight directory mirrors.
      * reduces the weighting of Exits to avoid overloading them.
      * places limits on the weight of any one fallback.
      * includes an IPv6 address and orport for each FallbackDir, as
        implemented in #17327. (Tor won't bootstrap using IPv6 fallbacks
        until #17840 is merged.)
      * generated output includes timestamps & Onionoo URL for traceability.
      * unit test ensures that we successfully load all included default
        fallback directories.
      
      Closes ticket #15775. Patch by "teor".
      OnionOO script by "weasel", "teor", "gsathya", and "karsten".
      4c1c2a31
    • Nick Mathewson's avatar
      Update KeepCapabilities based on comments from asn · 405a8d3f
      Nick Mathewson authored
      * The option is now KeepBindCapabilities
      * We now warn if the user specifically asked for KeepBindCapabilities
        and we can't deliver.
      * The unit tests are willing to start.
      * Fewer unused-variable warnings.
      * More documentation, fewer misspellings.
      405a8d3f
    • Nick Mathewson's avatar
      Add ability to keep the CAP_NET_BIND_SERVICE capability on Linux · e8cc839e
      Nick Mathewson authored
      This feature allows us to bind low ports when starting as root and
      switching UIDs.
      
      Based on code by David Goulet.
      
      Implement feature 8195
      e8cc839e
    • teor (Tim Wilson-Brown)'s avatar
      Prop210: Add schedules for simultaneous client consensus downloads · 35bbf2e4
      teor (Tim Wilson-Brown) authored
      Prop210: Add attempt-based connection schedules
      
      Existing tor schedules increment the schedule position on failure,
      then retry the connection after the scheduled time.
      
      To make multiple simultaneous connections, we need to increment the
      schedule position when making each attempt, then retry a (potentially
      simultaneous) connection after the scheduled time.
      
      (Also change find_dl_schedule_and_len to find_dl_schedule, as it no
      longer takes or returns len.)
      
      Prop210: Add multiple simultaneous consensus downloads for clients
      
      Make connections on TestingClientBootstrapConsensus*DownloadSchedule,
      incrementing the schedule each time the client attempts to connect.
      
      Check if the number of downloads is less than
      TestingClientBootstrapConsensusMaxInProgressTries before trying any
      more connections.
      35bbf2e4
    • teor (Tim Wilson-Brown)'s avatar
      Add UseDefaultFallbackDirs for hard-coded directory mirrors · 080ae03e
      teor (Tim Wilson-Brown) authored and Nick Mathewson's avatar Nick Mathewson committed
      UseDefaultFallbackDirs enables any hard-coded fallback
      directory mirrors. Default is 1, set it to 0 to disable fallbacks.
      
      Implements ticket 17576.
      Patch by "teor".
      080ae03e
  23. 14 Dec, 2015 3 commits