1. 30 Jun, 2016 2 commits
  2. 18 Jun, 2016 2 commits
  3. 30 May, 2016 1 commit
    • Nick Mathewson's avatar
      Replace nearly all XXX0vv comments with smarter ones · 4f1a04ff
      Nick Mathewson authored
      So, back long ago, XXX012 meant, "before Tor 0.1.2 is released, we
      had better revisit this comment and fix it!"
      
      But we have a huge pile of such comments accumulated for a large
      number of released versions!  Not cool.
      
      So, here's what I tried to do:
      
        * 0.2.9 and 0.2.8 are retained, since those are not yet released.
      
        * XXX+ or XXX++ or XXX++++ or whatever means, "This one looks
          quite important!"
      
        * The others, after one-by-one examination, are downgraded to
          plain old XXX.  Which doesn't mean they aren't a problem -- just
          that they cannot possibly be a release-blocking problem.
      4f1a04ff
  4. 27 May, 2016 2 commits
  5. 18 May, 2016 1 commit
    • Nick Mathewson's avatar
      Remove duplicate siging_key_cert fields. · ab932cd7
      Nick Mathewson authored
      With the fix for #17150, I added a duplicate certificate here.  Here
      I remove the original location in 0.2.8.  (I wouldn't want to do
      that in 027, due to the amount of authority-voting-related code
      drift.)
      
      Closes 19073.
      ab932cd7
  6. 17 May, 2016 2 commits
    • Nick Mathewson's avatar
      Copy the signing_key_cert field into signed_descriptor_t · 8acfac73
      Nick Mathewson authored
      We need this field to be in signed_descriptor_t so that
      routerinfo_incompatible_with_extrainfo can work correctly (#17150).
      But I don't want to move it completely in this patch, since a great
      deal of the code that messes with it has been in flux since 0.2.7,
      when this ticket was opened.  I should open another ticket about
      removing the field from routerinfo_t and extrainfo_t later on.
      
      This patch fixes no actual behavior.
      8acfac73
    • Nick Mathewson's avatar
      Move extra_info_digest256 into signed_descriptor_t · 44da47d3
      Nick Mathewson authored
      This patch includes no semantic changes; it's just a field movement.
      
      It's prerequisite for a fix to 19017/17150.
      44da47d3
  7. 09 May, 2016 1 commit
  8. 05 May, 2016 1 commit
  9. 07 Apr, 2016 1 commit
  10. 05 Apr, 2016 1 commit
  11. 26 Mar, 2016 1 commit
  12. 21 Mar, 2016 3 commits
    • Nick Mathewson's avatar
      Fix another case of 17668: Add NoEdConsensus · fa07c60c
      Nick Mathewson authored
      I had a half-built mechanism to track, during the voting process,
      whether the Ed25519 value (or lack thereof) reflected a true
      consensus among the authorities.  But we never actually inserted this
      field in the consensus.
      
      The key idea here is that we first attempt to match up votes by pairs
      of <Ed,RSA>, where <Ed> can be NULL if we're told that there is no
      Ed key.  If this succeeds, then we can treat all those votes as 'a
      consensus for Ed'.  And we can include all other votes with a
      matching RSA key and no statement about Ed keys as being "also about
      the same relay."
      
      After that, we look for RSA keys we haven't actually found an entry
      for yet, and see if there are enough votes for them, NOT considering
      Ed keys.  If there are, we match them as before, but we treat them
      as "not a consensus about ed".
      
      When we include an entry in a consensus, if it does not reflect a
      consensus about ed keys, then we include a new NoEdConsensus flag on
      it.
      
      This is all only for consensus method 22 or later.
      
      Also see corresponding dir-spec patch.
      fa07c60c
    • Nick Mathewson's avatar
      Document has_ed25519_listing · 60ca3f35
      Nick Mathewson authored
      60ca3f35
    • Nick Mathewson's avatar
      Never vote for an ed key twice. · 13a31e72
      Nick Mathewson authored
      When generating a vote, and we have two routerinfos with the same ed
      key, omit the one published earlier.
      
      This was supposed to have been solved by key pinning, but when I
      made key pinning optional, I didn't realize that this would jump up
      and bite us.  It is part of bug 18318, and the root cause of 17668.
      13a31e72
  13. 01 Mar, 2016 1 commit
  14. 27 Feb, 2016 1 commit
  15. 20 Feb, 2016 1 commit
  16. 11 Feb, 2016 1 commit
  17. 10 Feb, 2016 1 commit
    • Nick Mathewson's avatar
      Rename crypto_digest_all, and digests_t. · 8a4bba06
      Nick Mathewson authored
      They are no longer "all" digests, but only the "common" digests.
      
      Part of 17795.
      
      This is an automated patch I made with a couple of perl one-liners:
      
        perl -i -pe 's/crypto_digest_all/crypto_common_digests/g;' src/*/*.[ch]
        perl -i -pe 's/\bdigests_t\b/common_digests_t/g;' src/*/*.[ch]
      8a4bba06
  18. 28 Jan, 2016 3 commits
  19. 27 Jan, 2016 1 commit
  20. 26 Jan, 2016 1 commit
  21. 08 Jan, 2016 1 commit
  22. 03 Jan, 2016 1 commit
  23. 18 Dec, 2015 1 commit
  24. 16 Dec, 2015 3 commits
  25. 15 Dec, 2015 6 commits